Add command line flags to override test_compiler include directories#2638
Open
olestrohm-arm wants to merge 1 commit intoKhronosGroup:mainfrom
Open
Add command line flags to override test_compiler include directories#2638olestrohm-arm wants to merge 1 commit intoKhronosGroup:mainfrom
olestrohm-arm wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
This adds flags --include-test-directory and --second-include-test-directory flags to test_compiler to allow the user to specify their locations rather than relying on the test to infer their location based on the path of the test binary.
rjodinchr
reviewed
Apr 3, 2026
Contributor
rjodinchr
left a comment
rjodinchr
left a comment
There was a problem hiding this comment.
I'm not against that change, but I would go even further: we could create the directories & files at runtime under std::filesystem::temp_directory_path() so that we don't have to install anything.
What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds flags
--include-test-directoryand--second-include-test-directoryflags to test_compiler to allow the user to specify their locations rather than relying on the test to infer their location based on the path of the test binary.